diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java index 9a52acb245..c1da442a72 100644 --- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java +++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java @@ -285,7 +285,7 @@ public class TaskDefinitionServiceImpl extends BaseServiceImpl implements TaskDe taskDefinition.setFailRetryTimes(taskDefinitionLog.getFailRetryTimes()); taskDefinition.setFailRetryInterval(taskDefinitionLog.getFailRetryInterval()); taskDefinition.setTimeoutFlag(taskDefinitionLog.getTimeoutFlag()); - taskDefinition.setTaskTimeoutStrategy(taskDefinitionLog.getTaskTimeoutStrategy()); + taskDefinition.setTimeoutNotifyStrategy(taskDefinitionLog.getTimeoutNotifyStrategy()); taskDefinition.setTimeout(taskDefinitionLog.getTimeout()); taskDefinition.setUpdateTime(new Date()); taskDefinition.setResourceIds(taskDefinitionLog.getResourceIds()); diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskType.java index dc3e9a59df..59b0387e49 100644 --- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskType.java +++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskType.java @@ -87,6 +87,7 @@ public enum TaskType { } public static TaskType of(String descp) { + descp = descp.toLowerCase(); if (TASK_TYPE_MAP.containsKey(descp)) { return TASK_TYPE_MAP.get(descp); } diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelation.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelation.java index 9c04a67a5f..da97df6d06 100644 --- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelation.java +++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelation.java @@ -95,18 +95,6 @@ public class ProcessTaskRelation { */ private String conditionParams; - /** - * condition parameter list - */ - @TableField(exist = false) - private List conditionParamList; - - /** - * condition parameter map - */ - @TableField(exist = false) - private Map conditionParamMap; - /** * create time */ @@ -181,36 +169,9 @@ public class ProcessTaskRelation { } public void setConditionParams(String conditionParams) { - if (conditionParams == null) { - this.conditionParamList = new ArrayList<>(); - } else { - this.conditionParamList = JSONUtils.toList(conditionParams, Property.class); - } this.conditionParams = conditionParams; } - public List getConditionParamList() { - return conditionParamList; - } - - public void setConditionParamList(List conditionParamList) { - this.conditionParams = JSONUtils.toJsonString(conditionParamList); - this.conditionParamList = conditionParamList; - } - - public Map getConditionParamMap() { - if (conditionParamMap == null && StringUtils.isNotEmpty(conditionParams)) { - List propList = JSONUtils.toList(conditionParams, Property.class); - conditionParamMap = propList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue)); - } - - return conditionParamMap; - } - - public void setConditionParamMap(Map conditionParamMap) { - this.conditionParamMap = conditionParamMap; - } - public int getProcessDefinitionVersion() { return processDefinitionVersion; } diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelationLog.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelationLog.java index 36e67a60a0..5d460e2455 100644 --- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelationLog.java +++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessTaskRelationLog.java @@ -56,8 +56,6 @@ public class ProcessTaskRelationLog extends ProcessTaskRelation { this.setPostTaskVersion(processTaskRelation.getPostTaskVersion()); this.setConditionType(processTaskRelation.getConditionType()); this.setConditionParams(processTaskRelation.getConditionParams()); - this.setConditionParamList(processTaskRelation.getConditionParamList()); - this.setConditionParamMap(processTaskRelation.getConditionParamMap()); this.setCreateTime(processTaskRelation.getCreateTime()); this.setUpdateTime(processTaskRelation.getUpdateTime()); } diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java index c0c167b46d..fe7145aa18 100644 --- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java +++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java @@ -146,7 +146,7 @@ public class TaskDefinition { /** * timeout notify strategy */ - private TaskTimeoutStrategy taskTimeoutStrategy; + private TaskTimeoutStrategy timeoutNotifyStrategy; /** * task warning time out. unit: minute @@ -247,36 +247,25 @@ public class TaskDefinition { } public void setTaskParams(String taskParams) { - if (taskParams == null) { - this.taskParamList = new ArrayList<>(); - } else { - this.taskParamList = JSONUtils.toList(taskParams, Property.class); - } this.taskParams = taskParams; } public List getTaskParamList() { - return taskParamList; - } + List propList = JSONUtils.toList(JSONUtils.parseObject(taskParams).findValue("localParams").toString(), + Property.class); + return taskParamList = propList; - public void setTaskParamList(List taskParamList) { - this.taskParams = JSONUtils.toJsonString(taskParamList); - this.taskParamList = taskParamList; } public Map getTaskParamMap() { if (taskParamMap == null && StringUtils.isNotEmpty(taskParams)) { - List propList = JSONUtils.toList(taskParams, Property.class); + List propList = JSONUtils.toList(JSONUtils.parseObject(taskParams).findValue("localParams").toString(), + Property.class); taskParamMap = propList.stream().collect(Collectors.toMap(Property::getProp, Property::getValue)); } - return taskParamMap; } - public void setTaskParamMap(Map taskParamMap) { - this.taskParamMap = taskParamMap; - } - public int getTimeout() { return timeout; } @@ -357,12 +346,12 @@ public class TaskDefinition { this.failRetryInterval = failRetryInterval; } - public TaskTimeoutStrategy getTaskTimeoutStrategy() { - return taskTimeoutStrategy; + public TaskTimeoutStrategy getTimeoutNotifyStrategy() { + return timeoutNotifyStrategy; } - public void setTaskTimeoutStrategy(TaskTimeoutStrategy taskTimeoutStrategy) { - this.taskTimeoutStrategy = taskTimeoutStrategy; + public void setTimeoutNotifyStrategy(TaskTimeoutStrategy timeoutNotifyStrategy) { + this.timeoutNotifyStrategy = timeoutNotifyStrategy; } public TimeoutFlag getTimeoutFlag() { diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java index 3988bc0838..a1770b4dd8 100644 --- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java +++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java @@ -57,10 +57,8 @@ public class TaskDefinitionLog extends TaskDefinition { this.setProjectName(taskDefinition.getProjectName()); this.setResourceIds(taskDefinition.getResourceIds()); this.setTaskParams(taskDefinition.getTaskParams()); - this.setTaskParamList(taskDefinition.getTaskParamList()); - this.setTaskParamMap(taskDefinition.getTaskParamMap()); this.setTaskPriority(taskDefinition.getTaskPriority()); - this.setTaskTimeoutStrategy(taskDefinition.getTaskTimeoutStrategy()); + this.setTimeoutNotifyStrategy(taskDefinition.getTimeoutNotifyStrategy()); this.setTaskType(taskDefinition.getTaskType()); this.setTimeout(taskDefinition.getTimeout()); this.setTimeoutFlag(taskDefinition.getTimeoutFlag()); diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionLogMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionLogMapper.java index f41eb4dc0d..aa8fc15312 100644 --- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionLogMapper.java +++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionLogMapper.java @@ -53,7 +53,7 @@ public interface ProcessDefinitionLogMapper extends BaseMapper