From 72942ac32cc104d9842b54d9e395a06540708af9 Mon Sep 17 00:00:00 2001
From: zhuangchong <zhuangchong6@163.com>
Date: Wed, 28 Oct 2020 20:01:38 +0800
Subject: [PATCH] update test.

---
 .../java/org/apache/dolphinscheduler/alert/AlertServer.java    | 1 -
 .../org/apache/dolphinscheduler/alert/AlertServerTest.java     | 2 ++
 .../alert/processor/AlertRequestProcessorTest.java             | 3 +++
 .../apache/dolphinscheduler/alert/runner/AlertSenderTest.java  | 3 ++-
 4 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java b/dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
index 30b3d8eedf..54afc93442 100644
--- a/dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
+++ b/dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
@@ -158,7 +158,6 @@ public class AlertServer {
     }
 
     public static void main(String[] args) {
-        System.out.println(System.getProperty("user.dir"));
         AlertServer alertServer = AlertServer.getInstance();
         alertServer.start();
         Runtime.getRuntime().addShutdownHook(new Thread() {
diff --git a/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/AlertServerTest.java b/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/AlertServerTest.java
index dd9c5bd472..37d54c8ef9 100644
--- a/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/AlertServerTest.java
+++ b/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/AlertServerTest.java
@@ -29,6 +29,7 @@ import org.apache.dolphinscheduler.spi.alert.AlertChannel;
 
 import java.util.concurrent.ConcurrentHashMap;
 
+import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -71,6 +72,7 @@ public class AlertServerTest {
         PowerMockito.whenNew(AlertSender.class).withAnyArguments().thenReturn(alertSender);
 
         AlertServer alertServer = AlertServer.getInstance();
+        Assert.assertNotNull(alertServer);
 
         new Thread(() -> {
             alertServer.start(); })
diff --git a/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/processor/AlertRequestProcessorTest.java b/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/processor/AlertRequestProcessorTest.java
index 8102caec17..0126eb3dae 100644
--- a/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/processor/AlertRequestProcessorTest.java
+++ b/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/processor/AlertRequestProcessorTest.java
@@ -21,8 +21,10 @@ import org.apache.dolphinscheduler.alert.plugin.AlertPluginManager;
 import org.apache.dolphinscheduler.dao.AlertDao;
 import org.apache.dolphinscheduler.dao.PluginDao;
 import org.apache.dolphinscheduler.remote.command.Command;
+import org.apache.dolphinscheduler.remote.command.CommandType;
 import org.apache.dolphinscheduler.remote.command.alert.AlertSendRequestCommand;
 
+import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 import org.powermock.api.mockito.PowerMockito;
@@ -53,6 +55,7 @@ public class AlertRequestProcessorTest {
         Channel channel = PowerMockito.mock(Channel.class);
         AlertSendRequestCommand alertSendRequestCommand = new AlertSendRequestCommand(1,"title","content");
         Command reqCommand = alertSendRequestCommand.convert2Command();
+        Assert.assertEquals(CommandType.ALERT_SEND_REQUEST,reqCommand.getType());
         alertRequestProcessor.process(channel,reqCommand);
     }
 }
diff --git a/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/runner/AlertSenderTest.java b/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/runner/AlertSenderTest.java
index fbe172c2fb..aa358f6380 100644
--- a/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/runner/AlertSenderTest.java
+++ b/dolphinscheduler-alert/src/test/java/org/apache/dolphinscheduler/alert/runner/AlertSenderTest.java
@@ -173,8 +173,9 @@ public class AlertSenderTest {
         ConcurrentHashMap alertChannelMap = new ConcurrentHashMap<>();
         alertChannelMap.put(pluginName,alertChannelMock);
         PowerMockito.when(alertPluginManager.getAlertChannelMap()).thenReturn(alertChannelMap);
-
+        Assert.assertTrue(Boolean.parseBoolean(alertResult.getStatus()));
         alertSender.run();
+
     }
 
 }