From 6a233d670dfda37d7ab8e936533e91242bd4fe62 Mon Sep 17 00:00:00 2001 From: Baoqi Date: Thu, 11 Apr 2019 20:01:35 +0800 Subject: [PATCH] Fix:checkConnection should close connection to avoid connection leak --- .../java/cn/escheduler/api/service/DataSourceService.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/escheduler-api/src/main/java/cn/escheduler/api/service/DataSourceService.java b/escheduler-api/src/main/java/cn/escheduler/api/service/DataSourceService.java index 087c427eba..58c24bddc1 100644 --- a/escheduler-api/src/main/java/cn/escheduler/api/service/DataSourceService.java +++ b/escheduler-api/src/main/java/cn/escheduler/api/service/DataSourceService.java @@ -38,6 +38,7 @@ import org.springframework.transaction.annotation.Transactional; import java.sql.Connection; import java.sql.DriverManager; +import java.sql.SQLException; import java.util.*; /** @@ -399,6 +400,11 @@ public class DataSourceService extends BaseService{ Connection con = getConnection(type, parameter); if (con != null) { isConnection = true; + try { + con.close(); + } catch (SQLException e) { + logger.error("close connection fail at DataSourceService::checkConnection()", e); + } } return isConnection; }