@ -19,8 +19,8 @@ package org.apache.dolphinscheduler.api.controller;
import org.apache.dolphinscheduler.api.enums.Status ;
import org.apache.dolphinscheduler.api.service.ResourcesService ;
import org.apache.dolphinscheduler.api.service.UdfFuncService ;
import org.apache.dolphinscheduler.api.utils.Constants ;
import org.apache.dolphinscheduler.api.utils.Result ;
import org.apache.dolphinscheduler.common.Constants ;
import org.apache.dolphinscheduler.common.enums.ResourceType ;
import org.apache.dolphinscheduler.common.enums.UdfType ;
import org.apache.dolphinscheduler.common.utils.ParameterUtils ;
@ -65,26 +65,26 @@ public class ResourcesController extends BaseController{
*
* @param loginUser
* @param alias
* @param desc
* @param description
* @param file
* /
@ApiOperation ( value = "createResource" , notes = "CREATE_RESOURCE_NOTES" )
@ApiImplicitParams ( {
@ApiImplicitParam ( name = "type" , value = "RESOURCE_TYPE" , required = true , dataType = "ResourceType" ) ,
@ApiImplicitParam ( name = "name" , value = "RESOURCE_NAME" , required = true , dataType = "String" ) ,
@ApiImplicitParam ( name = "des" , value = "RESOURCE_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "description " , value = "RESOURCE_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "file" , value = "RESOURCE_FILE" , required = true , dataType = "MultipartFile" )
} )
@PostMapping ( value = "/create" )
public Result createResource ( @ApiIgnore @RequestAttribute ( value = Constants . SESSION_USER ) User loginUser ,
@RequestParam ( value = "type" ) ResourceType type ,
@RequestParam ( value = "name" ) String alias ,
@RequestParam ( value = "desc" , required = false ) String desc ,
@RequestParam ( value = "description " , required = false ) String description ,
@RequestParam ( "file" ) MultipartFile file ) {
try {
logger . info ( "login user {}, create resource, type: {}, resource alias: {}, desc: {}, file: {},{}" ,
loginUser . getUserName ( ) , type , alias , desc , file . getName ( ) , file . getOriginalFilename ( ) ) ;
return resourceService . createResource ( loginUser , alias , desc , type , file ) ;
loginUser . getUserName ( ) , type , alias , description , file . getName ( ) , file . getOriginalFilename ( ) ) ;
return resourceService . createResource ( loginUser , alias , description , type , file ) ;
} catch ( Exception e ) {
logger . error ( CREATE_RESOURCE_ERROR . getMsg ( ) , e ) ;
return error ( CREATE_RESOURCE_ERROR . getCode ( ) , CREATE_RESOURCE_ERROR . getMsg ( ) ) ;
@ -96,14 +96,14 @@ public class ResourcesController extends BaseController{
*
* @param loginUser
* @param alias
* @param desc
* @param description
* /
@ApiOperation ( value = "createResource" , notes = "CREATE_RESOURCE_NOTES" )
@ApiImplicitParams ( {
@ApiImplicitParam ( name = "id" , value = "RESOURCE_ID" , required = true , dataType = "Int" , example = "100" ) ,
@ApiImplicitParam ( name = "type" , value = "RESOURCE_TYPE" , required = true , dataType = "ResourceType" ) ,
@ApiImplicitParam ( name = "name" , value = "RESOURCE_NAME" , required = true , dataType = "String" ) ,
@ApiImplicitParam ( name = "des" , value = "RESOURCE_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "description " , value = "RESOURCE_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "file" , value = "RESOURCE_FILE" , required = true , dataType = "MultipartFile" )
} )
@PostMapping ( value = "/update" )
@ -111,11 +111,11 @@ public class ResourcesController extends BaseController{
@RequestParam ( value = "id" ) int resourceId ,
@RequestParam ( value = "type" ) ResourceType type ,
@RequestParam ( value = "name" ) String alias ,
@RequestParam ( value = "desc" , required = false ) String desc ) {
@RequestParam ( value = "description " , required = false ) String description ) {
try {
logger . info ( "login user {}, update resource, type: {}, resource alias: {}, desc: {}" ,
loginUser . getUserName ( ) , type , alias , desc ) ;
return resourceService . updateResource ( loginUser , resourceId , alias , desc , type ) ;
loginUser . getUserName ( ) , type , alias , description ) ;
return resourceService . updateResource ( loginUser , resourceId , alias , description , type ) ;
} catch ( Exception e ) {
logger . error ( UPDATE_RESOURCE_ERROR . getMsg ( ) , e ) ;
return error ( Status . UPDATE_RESOURCE_ERROR . getCode ( ) , Status . UPDATE_RESOURCE_ERROR . getMsg ( ) ) ;
@ -280,7 +280,7 @@ public class ResourcesController extends BaseController{
* @param type
* @param fileName
* @param fileSuffix
* @param desc
* @param description
* @param content
* @return
* /
@ -289,7 +289,7 @@ public class ResourcesController extends BaseController{
@ApiImplicitParam ( name = "type" , value = "RESOURCE_TYPE" , required = true , dataType = "ResourceType" ) ,
@ApiImplicitParam ( name = "fileName" , value = "RESOURCE_NAME" , required = true , dataType = "String" ) ,
@ApiImplicitParam ( name = "suffix" , value = "SUFFIX" , required = true , dataType = "String" ) ,
@ApiImplicitParam ( name = "des" , value = "RESOURCE_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "description " , value = "RESOURCE_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "content" , value = "CONTENT" , required = true , dataType = "String" )
} )
@PostMapping ( value = "/online-create" )
@ -297,17 +297,17 @@ public class ResourcesController extends BaseController{
@RequestParam ( value = "type" ) ResourceType type ,
@RequestParam ( value = "fileName" ) String fileName ,
@RequestParam ( value = "suffix" ) String fileSuffix ,
@RequestParam ( value = "desc" , required = false ) String desc ,
@RequestParam ( value = "description " , required = false ) String description ,
@RequestParam ( value = "content" ) String content
) {
try {
logger . info ( "login user {}, online create resource! fileName : {}, type : {}, suffix : {},desc : {},content : {}" ,
loginUser . getUserName ( ) , type , fileName , fileSuffix , desc , content ) ;
loginUser . getUserName ( ) , type , fileName , fileSuffix , description , content ) ;
if ( StringUtils . isEmpty ( content ) ) {
logger . error ( "resource file contents are not allowed to be empty" ) ;
return error ( Status . RESOURCE_FILE_IS_EMPTY . getCode ( ) , RESOURCE_FILE_IS_EMPTY . getMsg ( ) ) ;
}
return resourceService . onlineCreateResource ( loginUser , type , fileName , fileSuffix , desc , content ) ;
return resourceService . onlineCreateResource ( loginUser , type , fileName , fileSuffix , description , content ) ;
} catch ( Exception e ) {
logger . error ( CREATE_RESOURCE_FILE_ON_LINE_ERROR . getMsg ( ) , e ) ;
return error ( Status . CREATE_RESOURCE_FILE_ON_LINE_ERROR . getCode ( ) , Status . CREATE_RESOURCE_FILE_ON_LINE_ERROR . getMsg ( ) ) ;
@ -383,7 +383,7 @@ public class ResourcesController extends BaseController{
* @param funcName
* @param argTypes
* @param database
* @param desc
* @param description
* @param resourceId
* @return
* /
@ -394,7 +394,7 @@ public class ResourcesController extends BaseController{
@ApiImplicitParam ( name = "suffix" , value = "CLASS_NAME" , required = true , dataType = "String" ) ,
@ApiImplicitParam ( name = "argTypes" , value = "ARG_TYPES" , dataType = "String" ) ,
@ApiImplicitParam ( name = "database" , value = "DATABASE_NAME" , dataType = "String" ) ,
@ApiImplicitParam ( name = "desc" , value = "UDF_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "description " , value = "UDF_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "resourceId" , value = "RESOURCE_ID" , required = true , dataType = "Int" , example = "100" )
} )
@ -406,14 +406,14 @@ public class ResourcesController extends BaseController{
@RequestParam ( value = "className" ) String className ,
@RequestParam ( value = "argTypes" , required = false ) String argTypes ,
@RequestParam ( value = "database" , required = false ) String database ,
@RequestParam ( value = "desc" , required = false ) String desc ,
@RequestParam ( value = "description " , required = false ) String description ,
@RequestParam ( value = "resourceId" ) int resourceId ) {
logger . info ( "login user {}, create udf function, type: {}, funcName: {},argTypes: {} ,database: {},desc: {},resourceId: {}" ,
loginUser . getUserName ( ) , type , funcName , argTypes , database , desc , resourceId ) ;
loginUser . getUserName ( ) , type , funcName , argTypes , database , description , resourceId ) ;
Result result = new Result ( ) ;
try {
return udfFuncService . createUdfFunction ( loginUser , funcName , className , argTypes , database , desc , type , resourceId ) ;
return udfFuncService . createUdfFunction ( loginUser , funcName , className , argTypes , database , description , type , resourceId ) ;
} catch ( Exception e ) {
logger . error ( CREATE_UDF_FUNCTION_ERROR . getMsg ( ) , e ) ;
return error ( Status . CREATE_UDF_FUNCTION_ERROR . getCode ( ) , Status . CREATE_UDF_FUNCTION_ERROR . getMsg ( ) ) ;
@ -457,7 +457,7 @@ public class ResourcesController extends BaseController{
* @param funcName
* @param argTypes
* @param database
* @param desc
* @param description
* @param resourceId
* @return
* /
@ -468,7 +468,7 @@ public class ResourcesController extends BaseController{
@ApiImplicitParam ( name = "suffix" , value = "CLASS_NAME" , required = true , dataType = "String" ) ,
@ApiImplicitParam ( name = "argTypes" , value = "ARG_TYPES" , dataType = "String" ) ,
@ApiImplicitParam ( name = "database" , value = "DATABASE_NAME" , dataType = "String" ) ,
@ApiImplicitParam ( name = "desc" , value = "UDF_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "description " , value = "UDF_DESC" , dataType = "String" ) ,
@ApiImplicitParam ( name = "id" , value = "RESOURCE_ID" , required = true , dataType = "Int" , example = "100" )
} )
@ -480,12 +480,12 @@ public class ResourcesController extends BaseController{
@RequestParam ( value = "className" ) String className ,
@RequestParam ( value = "argTypes" , required = false ) String argTypes ,
@RequestParam ( value = "database" , required = false ) String database ,
@RequestParam ( value = "desc" , required = false ) String desc ,
@RequestParam ( value = "description " , required = false ) String description ,
@RequestParam ( value = "resourceId" ) int resourceId ) {
try {
logger . info ( "login user {}, updateProcessInstance udf function id: {},type: {}, funcName: {},argTypes: {} ,database: {},desc: {},resourceId: {}" ,
loginUser . getUserName ( ) , udfFuncId , type , funcName , argTypes , database , desc , resourceId ) ;
Map < String , Object > result = udfFuncService . updateUdfFunc ( udfFuncId , funcName , className , argTypes , database , desc , type , resourceId ) ;
loginUser . getUserName ( ) , udfFuncId , type , funcName , argTypes , database , description , resourceId ) ;
Map < String , Object > result = udfFuncService . updateUdfFunc ( udfFuncId , funcName , className , argTypes , database , description , type , resourceId ) ;
return returnDataList ( result ) ;
} catch ( Exception e ) {
logger . error ( UPDATE_UDF_FUNCTION_ERROR . getMsg ( ) , e ) ;