From 46660b58ed82d76904f26c5b869f3aa96e50727a Mon Sep 17 00:00:00 2001
From: QuakeWang <45645138+QuakeWang@users.noreply.github.com>
Date: Sat, 22 May 2021 23:56:39 +0800
Subject: [PATCH] [Test] Add SparkParameters test (#5478)

* Create SparkparametersTest.java

Add a test case

* Update and rename SparkparametersTest.java to SparkParametersTest.java

* Update pom.xml

add SparkParametersTest.java in pom file
---
 .../common/task/SparkParametersTest.java      | 61 +++++++++++++++++++
 pom.xml                                       |  1 +
 2 files changed, 62 insertions(+)
 create mode 100644 dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/task/SparkParametersTest.java

diff --git a/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/task/SparkParametersTest.java b/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/task/SparkParametersTest.java
new file mode 100644
index 0000000000..dbd98ed4fe
--- /dev/null
+++ b/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/task/SparkParametersTest.java
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.task;
+
+import org.apache.dolphinscheduler.common.process.ResourceInfo;
+import org.apache.dolphinscheduler.common.task.spark.SparkParameters;
+import org.apache.dolphinscheduler.common.utils.CollectionUtils;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class SparkParametersTest {
+
+    @Test
+    public void getResourceFilesList() {
+        SparkParameters sparkParameters = new SparkParameters();
+        Assert.assertTrue(CollectionUtils.isEmpty(sparkParameters.getResourceFilesList()));
+
+        ResourceInfo mainResource = new ResourceInfo();
+        mainResource.setRes("testSparkMain-1.0.0-SNAPSHOT.jar\"");
+        sparkParameters.setMainJar(mainResource);
+
+        LinkedList<ResourceInfo> resourceInfos = new LinkedList<>();
+        ResourceInfo resourceInfo1 = new ResourceInfo();
+        resourceInfo1.setRes("testSparkParameters1.jar");
+        resourceInfos.add(resourceInfo1);
+
+        sparkParameters.setResourceList(resourceInfos);
+        List<ResourceInfo> resourceFilesList = sparkParameters.getResourceFilesList();
+        Assert.assertNotNull(resourceFilesList);
+        Assert.assertEquals(2, resourceFilesList.size());
+
+        ResourceInfo resourceInfo2 = new ResourceInfo();
+        resourceInfo2.setRes("testSparkParameters2.jar");
+        resourceInfos.add(resourceInfo2);
+
+        sparkParameters.setResourceList(resourceInfos);
+        resourceFilesList = sparkParameters.getResourceFilesList();
+        Assert.assertNotNull(resourceFilesList);
+        Assert.assertEquals(3, resourceFilesList.size());
+
+    }
+}
diff --git a/pom.xml b/pom.xml
index 190c6d291f..062be48f8d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -861,6 +861,7 @@
                         <include>**/common/task/EntityTestUtils.java</include>
                         <include>**/common/task/FlinkParametersTest.java</include>
                         <include>**/common/task/HttpParametersTest.java</include>
+                        <include>**/common/task/SparkParametersTest.java</include>
                         <include>**/common/task/SqlParametersTest.java</include>
                         <include>**/common/task/SqoopParameterEntityTest.java</include>
                         <include>**/common/threadutils/ThreadPoolExecutorsTest.java</include>