diff --git a/escheduler-api/src/main/java/cn/escheduler/api/enums/Status.java b/escheduler-api/src/main/java/cn/escheduler/api/enums/Status.java index b99d3fa743..db050633cb 100644 --- a/escheduler-api/src/main/java/cn/escheduler/api/enums/Status.java +++ b/escheduler-api/src/main/java/cn/escheduler/api/enums/Status.java @@ -152,7 +152,8 @@ public enum Status { CREATE_QUEUE_ERROR(10127, "create queue error"), QUEUE_NOT_EXIST(10128, "queue {0} not exists"), QUEUE_EXIST(10129, "queue already exists"), - UPDATE_QUEUE_ERROR(10130, "update queue error"), + QUEUE_NAME_EXIST(10130, "queue name already exists"), + UPDATE_QUEUE_ERROR(10131, "update queue error"), UDF_FUNCTION_NOT_EXIST(20001, "UDF function not found"), diff --git a/escheduler-api/src/main/java/cn/escheduler/api/service/QueueService.java b/escheduler-api/src/main/java/cn/escheduler/api/service/QueueService.java index 621fd741e9..109719eb03 100644 --- a/escheduler-api/src/main/java/cn/escheduler/api/service/QueueService.java +++ b/escheduler-api/src/main/java/cn/escheduler/api/service/QueueService.java @@ -35,129 +35,151 @@ import java.util.Map; * queue service */ @Service -public class QueueService extends BaseService{ - - - @Autowired - private QueueMapper queueMapper; - - /** - * query queue list - * - * @param loginUser - * @return - */ - public Map queryList(User loginUser) { - Map result = new HashMap<>(5); - if (checkAdmin(loginUser, result)) { - return result; - } - - List queueList = queueMapper.queryAllQueue(); - result.put(Constants.DATA_LIST, queueList); - putMsg(result,Status.SUCCESS); - - return result; - } - - /** - * query queue list paging - * @param loginUser - * @param searchVal - * @param pageNo - * @param pageSize - * @return - */ - public Map queryList(User loginUser,String searchVal, Integer pageNo, Integer pageSize) { - Map result = new HashMap<>(5); - if (checkAdmin(loginUser, result)) { - return result; - } - - Integer count = queueMapper.countQueuePaging(searchVal); +public class QueueService extends BaseService { - PageInfo pageInfo = new PageInfo<>(pageNo,pageSize); - List queueList = queueMapper.queryQueuePaging(searchVal,pageInfo.getStart(),pageSize); + @Autowired + private QueueMapper queueMapper; - pageInfo.setTotalCount(count); - pageInfo.setLists(queueList); - result.put(Constants.DATA_LIST, pageInfo); - putMsg(result,Status.SUCCESS); + /** + * query queue list + * + * @param loginUser + * @return + */ + public Map queryList(User loginUser) { + Map result = new HashMap<>(5); + if (checkAdmin(loginUser, result)) { + return result; + } - return result; - } + List queueList = queueMapper.queryAllQueue(); + result.put(Constants.DATA_LIST, queueList); + putMsg(result, Status.SUCCESS); - public Map createQueue(User loginUser,String queue, String queueName) { - Map result = new HashMap<>(5); - if (checkAdmin(loginUser, result)) { - return result; + return result; } - if (checkQueueExists(queue)){ - putMsg(result, Status.QUEUE_EXIST, queue); - return result; + /** + * query queue list paging + * + * @param loginUser + * @param searchVal + * @param pageNo + * @param pageSize + * @return + */ + public Map queryList(User loginUser, String searchVal, Integer pageNo, Integer pageSize) { + Map result = new HashMap<>(5); + if (checkAdmin(loginUser, result)) { + return result; + } + + Integer count = queueMapper.countQueuePaging(searchVal); + + PageInfo pageInfo = new PageInfo<>(pageNo, pageSize); + + List queueList = queueMapper.queryQueuePaging(searchVal, pageInfo.getStart(), pageSize); + + pageInfo.setTotalCount(count); + pageInfo.setLists(queueList); + result.put(Constants.DATA_LIST, pageInfo); + putMsg(result, Status.SUCCESS); + + return result; } - Queue queueObj = new Queue(); - Date now = new Date(); - - queueObj.setQueue(queue); - queueObj.setQueueName(queueName); - queueObj.setCreateTime(now); - queueObj.setUpdateTime(now); - - queueMapper.insert(queueObj); - putMsg(result, Status.SUCCESS); - - return result; - } - - public Map updateQueue(User loginUser,int id,String queue, String queueName) { - Map result = new HashMap<>(5); - if (checkAdmin(loginUser, result)) { - return result; + /** + * create queue + * + * @param loginUser + * @param queue + * @param queueName + * @return + */ + public Map createQueue(User loginUser, String queue, String queueName) { + Map result = new HashMap<>(5); + if (checkAdmin(loginUser, result)) { + return result; + } + + if (checkQueueExists(queue)) { + putMsg(result, Status.QUEUE_EXIST, queue); + return result; + } + + if (checkQueueExists(queueName)) { + putMsg(result, Status.QUEUE_NAME_EXIST, queueName); + return result; + } + + Queue queueObj = new Queue(); + Date now = new Date(); + + queueObj.setQueue(queue); + queueObj.setQueueName(queueName); + queueObj.setCreateTime(now); + queueObj.setUpdateTime(now); + + queueMapper.insert(queueObj); + putMsg(result, Status.SUCCESS); + + return result; } - - - Queue queueObj = queueMapper.queryById(id); - if (queueObj == null) { - putMsg(result,Status.QUEUE_NOT_EXIST,id); - return result; + /** + * update queue + * + * @param loginUser + * @param id + * @param queue + * @param queueName + * @return + */ + public Map updateQueue(User loginUser, int id, String queue, String queueName) { + Map result = new HashMap<>(5); + if (checkAdmin(loginUser, result)) { + return result; + } + + + Queue queueObj = queueMapper.queryById(id); + if (queueObj == null) { + putMsg(result, Status.QUEUE_NOT_EXIST, id); + return result; + } + + //update queue + + if (StringUtils.isNotEmpty(queue)) { + if (!queue.equals(queueObj.getQueue()) && checkQueueExists(queue)) { + putMsg(result, Status.QUEUE_EXIST, queue); + return result; + } + queueObj.setQueue(queue); + } + if (StringUtils.isNotEmpty(queueName)) { + queueObj.setQueueName(queueName); + } + Date now = new Date(); + + queueObj.setUpdateTime(now); + + queueMapper.update(queueObj); + putMsg(result, Status.SUCCESS); + + return result; } - //update queue - if (StringUtils.isNotEmpty(queue)) { - if (!queue.equals(queueObj.getQueue()) && checkQueueExists(queue)) { - putMsg(result, Status.QUEUE_EXIST, queue); - return result; - } - queueObj.setQueue(queue); + /** + * check queue exists + * + * @param queue + * @return + */ + private boolean checkQueueExists(String queue) { + return queueMapper.queryByQueue(queue) == null ? false : true; } - if (StringUtils.isNotEmpty(queueName)) { - queueObj.setQueueName(queueName); - } - Date now = new Date(); - - queueObj.setUpdateTime(now); - - queueMapper.update(queueObj); - putMsg(result, Status.SUCCESS); - - return result; - } - - - /** - * check queue exists - * - * @param queue - * @return - */ - private boolean checkQueueExists(String queue) { - return queueMapper.queryByQueue(queue) == null ? false : true; - } }