From 2b2adecd85792440690aee94ba4eb8e59c931859 Mon Sep 17 00:00:00 2001 From: Bharati Kulkarni <31247303+bmk15897@users.noreply.github.com> Date: Wed, 7 Dec 2022 23:40:08 -0600 Subject: [PATCH] [Improvement] Fixed Possible JSON ordering permutations problem in Tests (#13118) * Fixed flaky test * Fixed imports order --- .../spi/params/PluginParamsTransferTest.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dolphinscheduler-spi/src/test/java/org/apache/dolphinscheduler/spi/params/PluginParamsTransferTest.java b/dolphinscheduler-spi/src/test/java/org/apache/dolphinscheduler/spi/params/PluginParamsTransferTest.java index 1f88584a83..72fae3d56d 100644 --- a/dolphinscheduler-spi/src/test/java/org/apache/dolphinscheduler/spi/params/PluginParamsTransferTest.java +++ b/dolphinscheduler-spi/src/test/java/org/apache/dolphinscheduler/spi/params/PluginParamsTransferTest.java @@ -32,6 +32,9 @@ import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import com.google.gson.JsonElement; +import com.google.gson.JsonParser; + /** * PluginParamsTransfer Tester. */ @@ -178,7 +181,9 @@ public class PluginParamsTransferTest { + ",\"disabled\":false},{\"label\":\"text\",\"value\":\"text\",\"disabled\":false},{\"label\"" + ":\"attachment\",\"value\":\"attachment\",\"disabled\":false},{\"label\":\"tableattachment\"" + ",\"value\":\"tableattachment\",\"disabled\":false}]}]"; - Assertions.assertEquals(paramsJsonAssert, paramsJson); + JsonElement paramsJsonElement = JsonParser.parseString(paramsJson); + JsonElement paramsAssertJsonElement = JsonParser.parseString(paramsJsonAssert); + Assertions.assertEquals(paramsAssertJsonElement, paramsJsonElement); } @Test