From 233bbdb09ebb6756a8b8578d4da7ec51820b2873 Mon Sep 17 00:00:00 2001 From: rickchengx <38122586+rickchengx@users.noreply.github.com> Date: Tue, 25 Oct 2022 11:25:30 +0800 Subject: [PATCH] [Fix-12451][k8s] Read the kubeconfig from cluster conf (#12452) --- .../java/org/apache/dolphinscheduler/api/k8s/K8sManager.java | 2 +- .../dolphinscheduler/api/service/impl/ClusterServiceImpl.java | 2 +- .../dolphinscheduler/service/process/ProcessServiceImpl.java | 3 ++- .../dolphinscheduler/service}/utils/ClusterConfUtils.java | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) rename {dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api => dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service}/utils/ClusterConfUtils.java (96%) diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/k8s/K8sManager.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/k8s/K8sManager.java index 422075cbd7..6b573baa42 100644 --- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/k8s/K8sManager.java +++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/k8s/K8sManager.java @@ -17,10 +17,10 @@ package org.apache.dolphinscheduler.api.k8s; -import org.apache.dolphinscheduler.api.utils.ClusterConfUtils; import org.apache.dolphinscheduler.dao.entity.Cluster; import org.apache.dolphinscheduler.dao.mapper.ClusterMapper; import org.apache.dolphinscheduler.remote.exceptions.RemotingException; +import org.apache.dolphinscheduler.service.utils.ClusterConfUtils; import java.util.Hashtable; import java.util.Map; diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceImpl.java index 18daab3e1e..be3f6d2971 100644 --- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceImpl.java +++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceImpl.java @@ -21,7 +21,6 @@ import org.apache.dolphinscheduler.api.dto.ClusterDto; import org.apache.dolphinscheduler.api.enums.Status; import org.apache.dolphinscheduler.api.k8s.K8sManager; import org.apache.dolphinscheduler.api.service.ClusterService; -import org.apache.dolphinscheduler.api.utils.ClusterConfUtils; import org.apache.dolphinscheduler.api.utils.PageInfo; import org.apache.dolphinscheduler.api.utils.Result; import org.apache.dolphinscheduler.common.constants.Constants; @@ -33,6 +32,7 @@ import org.apache.dolphinscheduler.dao.entity.User; import org.apache.dolphinscheduler.dao.mapper.ClusterMapper; import org.apache.dolphinscheduler.dao.mapper.K8sNamespaceMapper; import org.apache.dolphinscheduler.remote.exceptions.RemotingException; +import org.apache.dolphinscheduler.service.utils.ClusterConfUtils; import org.apache.commons.collections.CollectionUtils; import org.apache.commons.lang3.StringUtils; diff --git a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java index b8899f2100..dd65097585 100644 --- a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java +++ b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java @@ -133,6 +133,7 @@ import org.apache.dolphinscheduler.service.expand.CuringParamsService; import org.apache.dolphinscheduler.service.log.LogClient; import org.apache.dolphinscheduler.service.model.TaskNode; import org.apache.dolphinscheduler.service.task.TaskPluginManager; +import org.apache.dolphinscheduler.service.utils.ClusterConfUtils; import org.apache.dolphinscheduler.service.utils.DagHelper; import org.apache.dolphinscheduler.spi.enums.ResourceType; @@ -2922,7 +2923,7 @@ public class ProcessServiceImpl implements ProcessService { QueryWrapper nodeWrapper = new QueryWrapper<>(); nodeWrapper.eq("name", clusterName); Cluster cluster = clusterMapper.selectOne(nodeWrapper); - return cluster == null ? null : cluster.getConfig(); + return cluster == null ? null : ClusterConfUtils.getK8sConfig(cluster.getConfig()); } @Override diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ClusterConfUtils.java b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/utils/ClusterConfUtils.java similarity index 96% rename from dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ClusterConfUtils.java rename to dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/utils/ClusterConfUtils.java index 5a7f6a84fa..5a607e077d 100644 --- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ClusterConfUtils.java +++ b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/utils/ClusterConfUtils.java @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.dolphinscheduler.api.utils; +package org.apache.dolphinscheduler.service.utils; import org.apache.dolphinscheduler.common.utils.JSONUtils;