From 10c295eae5e68ace45fcd2e19013e2746db2d35e Mon Sep 17 00:00:00 2001 From: juzimao <578961953@qq.com> Date: Tue, 28 Jun 2022 22:51:09 +0800 Subject: [PATCH] [Fix-10641] [Common] Fix the hdfs NPE (#10642) Fix the hdfs NPE (#10642) --- .../common/utils/HadoopUtils.java | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java index ec4286e8a1..314d946b60 100644 --- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java +++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java @@ -123,21 +123,25 @@ public class HadoopUtils implements Closeable, StorageOperate { } String defaultFS = configuration.get(Constants.FS_DEFAULT_FS); + + if (StringUtils.isBlank(defaultFS)){ + defaultFS= PropertyUtils.getString(Constants.FS_DEFAULT_FS); + } + //first get key from core-site.xml hdfs-site.xml ,if null ,then try to get from properties file // the default is the local file system - if (defaultFS.startsWith("file")) { - String defaultFSProp = PropertyUtils.getString(Constants.FS_DEFAULT_FS); - if (StringUtils.isNotBlank(defaultFSProp)) { - Map fsRelatedProps = PropertyUtils.getPrefixedProperties("fs."); - configuration.set(Constants.FS_DEFAULT_FS, defaultFSProp); - fsRelatedProps.forEach((key, value) -> configuration.set(key, value)); - } else { - logger.error("property:{} can not to be empty, please set!", Constants.FS_DEFAULT_FS); - throw new NullPointerException( - String.format("property: %s can not to be empty, please set!", Constants.FS_DEFAULT_FS) - ); - } + if (StringUtils.isNotBlank(defaultFS)) { + Map fsRelatedProps = PropertyUtils.getPrefixedProperties("fs."); + configuration.set(Constants.FS_DEFAULT_FS, defaultFS); + fsRelatedProps.forEach((key, value) -> configuration.set(key, value)); } else { + logger.error("property:{} can not to be empty, please set!", Constants.FS_DEFAULT_FS); + throw new NullPointerException( + String.format("property: %s can not to be empty, please set!", Constants.FS_DEFAULT_FS) + ); + } + + if (!defaultFS.startsWith("file")) { logger.info("get property:{} -> {}, from core-site.xml hdfs-site.xml ", Constants.FS_DEFAULT_FS, defaultFS); }