From 0fdb001319e1f6c6385e0cffab298d2d51a7859d Mon Sep 17 00:00:00 2001 From: zhuangchong Date: Wed, 28 Oct 2020 10:36:25 +0800 Subject: [PATCH] update ut. --- dolphinscheduler-remote/pom.xml | 4 ---- .../alert/AlertSendResponseCommand.java | 18 ++---------------- .../alert/AlertSendRequestCommandTest.java | 5 +++++ 3 files changed, 7 insertions(+), 20 deletions(-) diff --git a/dolphinscheduler-remote/pom.xml b/dolphinscheduler-remote/pom.xml index bc71241076..4d398f3069 100644 --- a/dolphinscheduler-remote/pom.xml +++ b/dolphinscheduler-remote/pom.xml @@ -35,10 +35,6 @@ - - org.apache.dolphinscheduler - dolphinscheduler-spi - io.netty netty-all diff --git a/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendResponseCommand.java b/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendResponseCommand.java index fbde4cfe51..e3cb1474a5 100644 --- a/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendResponseCommand.java +++ b/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendResponseCommand.java @@ -31,25 +31,11 @@ public class AlertSendResponseCommand implements Serializable { * true:All alert are successful, * false:As long as one alert fails */ - private boolean alertStatus; + private boolean resStatus; - private List alertResults; + private List resResults; - public boolean getAlertStatus() { - return alertStatus; - } - - public void setAlertStatus(boolean alertStatus) { - this.alertStatus = alertStatus; - } - public List getAlertResults() { - return alertResults; - } - - public void setAlertResults(List alertResults) { - this.alertResults = alertResults; - } public AlertSendResponseCommand() { diff --git a/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendRequestCommandTest.java b/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendRequestCommandTest.java index 4d0e59c082..79d21316f8 100644 --- a/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendRequestCommandTest.java +++ b/dolphinscheduler-remote/src/test/java/org/apache/dolphinscheduler/remote/command/alert/AlertSendRequestCommandTest.java @@ -33,5 +33,10 @@ public class AlertSendRequestCommandTest { AlertSendRequestCommand requestCommand = new AlertSendRequestCommand(groupId,title,content); Command command = requestCommand.convert2Command(); Assert.assertEquals(CommandType.ALERT_SEND_REQUEST,command.getType()); + AlertSendRequestCommand verifyCommand = new AlertSendRequestCommand(); + verifyCommand.setGroupId(groupId); + verifyCommand.setContent(content); + verifyCommand.setTitle(title); + } }