From 0c91564b4c02967acf925296deefbad62be2e1a7 Mon Sep 17 00:00:00 2001 From: Yelli Date: Fri, 5 Jun 2020 10:32:35 +0800 Subject: [PATCH] fix bug: sqoop mysql import params error (#2896) * fix bug: sqoop mysql import params error * fix bug: sqoop mysql import params error --- .../sources/MysqlSourceGenerator.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java index 404f10bf39..6527042af7 100644 --- a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java +++ b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sqoop/generator/sources/MysqlSourceGenerator.java @@ -77,35 +77,35 @@ public class MysqlSourceGenerator implements ISourceGenerator { }else{ srcQuery += " WHERE $CONDITIONS"; } - result.append(" --query \'"+srcQuery+"\'"); + result.append(" --query \'").append(srcQuery).append("\'"); } List mapColumnHive = sourceMysqlParameter.getMapColumnHive(); if(mapColumnHive != null && !mapColumnHive.isEmpty()){ - String columnMap = ""; + StringBuilder columnMap = new StringBuilder(); for(Property item:mapColumnHive){ - columnMap = item.getProp()+"="+ item.getValue()+","; + columnMap.append(item.getProp()).append("=").append(item.getValue()).append(","); } - if(StringUtils.isNotEmpty(columnMap)){ + if(StringUtils.isNotEmpty(columnMap.toString())){ result.append(" --map-column-hive ") - .append(columnMap.substring(0,columnMap.length()-1)); + .append(columnMap.substring(0,columnMap.length() - 1)); } } List mapColumnJava = sourceMysqlParameter.getMapColumnJava(); if(mapColumnJava != null && !mapColumnJava.isEmpty()){ - String columnMap = ""; + StringBuilder columnMap = new StringBuilder(); for(Property item:mapColumnJava){ - columnMap = item.getProp()+"="+ item.getValue()+","; + columnMap.append(item.getProp()).append("=").append(item.getValue()).append(","); } - if(StringUtils.isNotEmpty(columnMap)){ + if(StringUtils.isNotEmpty(columnMap.toString())){ result.append(" --map-column-java ") - .append(columnMap.substring(0,columnMap.length()-1)); + .append(columnMap.substring(0,columnMap.length() - 1)); } } }