Browse Source

refactor code style

pull/3/MERGE
baoliang 4 years ago
parent
commit
0ba8a6bc18
  1. 12
      dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/ResourceDao.java

12
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/ResourceDao.java

@ -18,6 +18,7 @@
package org.apache.dolphinscheduler.dao.upgrade; package org.apache.dolphinscheduler.dao.upgrade;
import org.apache.dolphinscheduler.common.utils.ConnectionUtils; import org.apache.dolphinscheduler.common.utils.ConnectionUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -35,11 +36,12 @@ public class ResourceDao {
/** /**
* list all resources * list all resources
*
* @param conn connection * @param conn connection
* @return map that key is full_name and value is id * @return map that key is full_name and value is id
*/ */
Map<String,Integer> listAllResources(Connection conn){ Map<String, Integer> listAllResources(Connection conn) {
Map<String,Integer> resourceMap = new HashMap<>(); Map<String, Integer> resourceMap = new HashMap<>();
String sql = String.format("SELECT id,full_name FROM t_ds_resources"); String sql = String.format("SELECT id,full_name FROM t_ds_resources");
ResultSet rs = null; ResultSet rs = null;
@ -48,14 +50,14 @@ public class ResourceDao {
pstmt = conn.prepareStatement(sql); pstmt = conn.prepareStatement(sql);
rs = pstmt.executeQuery(); rs = pstmt.executeQuery();
while (rs.next()){ while (rs.next()) {
Integer id = rs.getInt(1); Integer id = rs.getInt(1);
String fullName = rs.getString(2); String fullName = rs.getString(2);
resourceMap.put(fullName,id); resourceMap.put(fullName, id);
} }
} catch (Exception e) { } catch (Exception e) {
logger.error(e.getMessage(),e); logger.error(e.getMessage(), e);
throw new RuntimeException("sql: " + sql, e); throw new RuntimeException("sql: " + sql, e);
} finally { } finally {
ConnectionUtils.releaseResource(rs, pstmt, conn); ConnectionUtils.releaseResource(rs, pstmt, conn);

Loading…
Cancel
Save