Browse Source

Open checkstyle, change checkstyle severity from info to warning (#10492)

* Open checkstyle, change checkstyle severity from info to warning
3.1.0-release
Wenjun Ruan 2 years ago committed by GitHub
parent
commit
00f86da1da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      .github/workflows/api-test.yml
  2. 2
      .github/workflows/e2e.yml
  3. 2
      .github/workflows/publish-docker.yaml
  4. 2
      .github/workflows/py-ci.yml
  5. 2
      .github/workflows/unit-test.yml
  6. 7
      style/checkstyle.xml

2
.github/workflows/api-test.yml

@ -65,7 +65,7 @@ jobs:
./mvnw -B clean install \ ./mvnw -B clean install \
-Dmaven.test.skip \ -Dmaven.test.skip \
-Dmaven.javadoc.skip \ -Dmaven.javadoc.skip \
-Dmaven.checkstyle.skip \ -Dcheckstyle.skip=true \
-Pdocker,release -Ddocker.tag=ci \ -Pdocker,release -Ddocker.tag=ci \
-pl dolphinscheduler-standalone-server -am -pl dolphinscheduler-standalone-server -am
- name: Export Docker Images - name: Export Docker Images

2
.github/workflows/e2e.yml

@ -65,7 +65,7 @@ jobs:
./mvnw -B clean install \ ./mvnw -B clean install \
-Dmaven.test.skip \ -Dmaven.test.skip \
-Dmaven.javadoc.skip \ -Dmaven.javadoc.skip \
-Dmaven.checkstyle.skip \ -Dcheckstyle.skip=true \
-Pdocker,release -Ddocker.tag=ci \ -Pdocker,release -Ddocker.tag=ci \
-pl dolphinscheduler-standalone-server -am -pl dolphinscheduler-standalone-server -am
- name: Export Docker Images - name: Export Docker Images

2
.github/workflows/publish-docker.yaml

@ -56,7 +56,7 @@ jobs:
./mvnw -B clean deploy \ ./mvnw -B clean deploy \
-Dmaven.test.skip \ -Dmaven.test.skip \
-Dmaven.javadoc.skip \ -Dmaven.javadoc.skip \
-Dmaven.checkstyle.skip \ -Dcheckstyle.skip=true \
-Dmaven.deploy.skip \ -Dmaven.deploy.skip \
-Ddocker.tag=${{ github.sha }} \ -Ddocker.tag=${{ github.sha }} \
-Ddocker.hub=${{ env.HUB }} \ -Ddocker.hub=${{ env.HUB }} \

2
.github/workflows/py-ci.yml

@ -137,7 +137,7 @@ jobs:
./mvnw -B clean install \ ./mvnw -B clean install \
-Dmaven.test.skip \ -Dmaven.test.skip \
-Dmaven.javadoc.skip \ -Dmaven.javadoc.skip \
-Dmaven.checkstyle.skip \ -Dcheckstyle.skip=true \
-Pdocker,release -Ddocker.tag=ci \ -Pdocker,release -Ddocker.tag=ci \
-pl dolphinscheduler-standalone-server -am -pl dolphinscheduler-standalone-server -am
- name: Export Docker Images - name: Export Docker Images

2
.github/workflows/unit-test.yml

@ -71,7 +71,7 @@ jobs:
key: ${{ runner.os }}-maven key: ${{ runner.os }}-maven
- name: Run Unit tests - name: Run Unit tests
run: ./mvnw clean verify -B -Dmaven.test.skip=false run: ./mvnw clean verify -B -Dmaven.test.skip=false -Dcheckstyle.skip=true
- name: Upload coverage report to codecov - name: Upload coverage report to codecov
run: CODECOV_TOKEN="09c2663f-b091-4258-8a47-c981827eb29a" bash <(curl -s https://codecov.io/bash) run: CODECOV_TOKEN="09c2663f-b091-4258-8a47-c981827eb29a" bash <(curl -s https://codecov.io/bash)

7
style/checkstyle.xml

@ -21,7 +21,9 @@
<module name="Checker"> <module name="Checker">
<property name="charset" value="UTF-8"/> <property name="charset" value="UTF-8"/>
<property name="severity" value="info"/> <property name="severity" value="warning"/>
<module name="SuppressWarningsFilter"/>
<property name="fileExtensions" value="java, properties, xml"/> <property name="fileExtensions" value="java, properties, xml"/>
@ -40,6 +42,9 @@
</module> </module>
<module name="TreeWalker"> <module name="TreeWalker">
<module name="SuppressWarningsHolder"/>
<module name="OuterTypeFilename"> <module name="OuterTypeFilename">
<property name="severity" value="error"/> <property name="severity" value="error"/>
</module> </module>

Loading…
Cancel
Save