From f5dc6736603b19ba664985d08f1b22907af69783 Mon Sep 17 00:00:00 2001 From: Jiaju Zhuang Date: Fri, 17 Sep 2021 11:47:25 +0800 Subject: [PATCH 1/2] =?UTF-8?q?=E6=96=B0=E5=A2=9Epr=E6=A8=A1=E6=9D=BF?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md new file mode 100644 index 00000000..c598ad80 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -0,0 +1,9 @@ +## 关联的ISSUE +TODO 请说明关联的异常 +## 问题描述&解决 +TODO 描述下出了什么问题，必要的话提供excel。在PR合并前，审核同学一定会复现问题，然后再PR合并的。 +## 代码注意点 +* 确认已经安装了阿里巴巴代码规约插件：[alibaba-java-coding-guidelines ](https://plugins.jetbrains.com/plugin/10046-alibaba-java-coding-guidelines) +* src/main 下面不要出现中文注释 +* src/test/core && src/test/demo 下面要新增测试案例请严格参照其他的，包括注释等等什么都不要错 +* 如果改动量较大（5+文件）尽量先和作者沟通，这个风险很大 \ No newline at end of file From 0d272acec669ba734a44aecb8c605ff5ebc36b6a Mon Sep 17 00:00:00 2001 From: Jiaju Zhuang Date: Fri, 17 Sep 2021 12:14:51 +0800 Subject: [PATCH 2/2] =?UTF-8?q?=E6=96=B0=E5=A2=9Epr=E6=A8=A1=E6=9D=BF?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index c598ad80..b89c0b86 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -6,4 +6,5 @@ TODO 描述下出了什么问题，必要的话提供excel。在PR合并前， * 确认已经安装了阿里巴巴代码规约插件：[alibaba-java-coding-guidelines ](https://plugins.jetbrains.com/plugin/10046-alibaba-java-coding-guidelines) * src/main 下面不要出现中文注释 * src/test/core && src/test/demo 下面要新增测试案例请严格参照其他的，包括注释等等什么都不要错 +* 如果只是自己测试 全部加入到 src/test/temp * 如果改动量较大（5+文件）尽量先和作者沟通，这个风险很大 \ No newline at end of file