From f5e26549e5ba933e817ddbb9281d8ac47f56c0dc Mon Sep 17 00:00:00 2001
From: fr_shine <zheng@finereport.com>
Date: Tue, 17 May 2016 17:44:48 +0800
Subject: [PATCH] =?UTF-8?q?=E5=9C=B0=E5=9B=BE=E9=85=8D=E7=BD=AE?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../table/SeriesNameUseFieldNamePane.java     | 18 +++++--
 .../table/SeriesNameUseFieldValuePane.java    | 47 ++++++++++++++-----
 .../data/table/SeriesTypeUseComboxPane.java   | 12 ++++-
 3 files changed, 59 insertions(+), 18 deletions(-)

diff --git a/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldNamePane.java b/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldNamePane.java
index 8e6784d927..f9258bc81e 100644
--- a/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldNamePane.java
+++ b/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldNamePane.java
@@ -89,15 +89,25 @@ public class SeriesNameUseFieldNamePane extends FurtherBasicBeanPane<ChartCollec
         double f = TableLayout.FILL;
         double[] columnSize = {f};
         double[] rowSize = {p, p};
-        Component[][] components = new Component[][]{
-                new Component[]{seriesDataPane},
-                new Component[]{new BoldFontTextLabel(Inter.getLocText("FR-Chart-Data_Filter"))},
-        };
+        Component[][] components = getUseComponent();
         centerPane = TableLayoutHelper.createTableLayoutPane(components, rowSize, columnSize);
         this.setLayout(new BorderLayout());
         this.add(centerPane, BorderLayout.CENTER);
     }
 
+    protected Component[][] getUseComponent() {
+        return new Component[][]{
+                new Component[]{seriesDataPane},
+                new Component[]{new BoldFontTextLabel(Inter.getLocText("FR-Chart-Data_Filter"))},
+        };
+    }
+
+    protected Component[][] getUseComponentWithOutFilter() {
+        return new Component[][]{
+                new Component[]{seriesDataPane}
+        };
+    }
+
     /**
      * 判断是都接受
      * @param ob 传过来得
diff --git a/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldValuePane.java b/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldValuePane.java
index f068bbbddb..a1eed21384 100644
--- a/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldValuePane.java
+++ b/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesNameUseFieldValuePane.java
@@ -82,13 +82,7 @@ public class SeriesNameUseFieldValuePane extends FurtherBasicBeanPane<ChartColle
         Label2.setPreferredSize(new Dimension(75, 20));
         UILabel Label3 = new UILabel(Inter.getLocText("Chart-Summary_Method") + ":", SwingConstants.RIGHT);
         Label3.setPreferredSize(new Dimension(75, 20));
-        Component[][] components = new Component[][]{
-                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesName, null, null, Label1, null})},
-                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesValue, null, null, Label2, null})},
-                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{calculateCombox, null, null, Label3, null})},
-                new Component[]{new JSeparator()},
-                new Component[]{new BoldFontTextLabel(Inter.getLocText("Chart-Data_Filter"))},
-        };
+        Component[][] components = getUseComponent(Label1, Label2, Label3);
 
         centerPane = TableLayoutHelper.createGapTableLayoutPane(components, rowSize, columnSize, 4, 6);
         centerPane.setBorder(BorderFactory.createEmptyBorder(0, 0, 0, 1));
@@ -107,17 +101,46 @@ public class SeriesNameUseFieldValuePane extends FurtherBasicBeanPane<ChartColle
         Label2.setPreferredSize(new Dimension(75, 20));
         UILabel Label3 = new UILabel(Inter.getLocText("Chart-Summary_Method") + ":", SwingConstants.RIGHT);
         Label3.setPreferredSize(new Dimension(75, 20));
-        Component[][] components = new Component[][]{
+        Component[][] components = getUseComponentWithOutSummary(Label1, Label2, Label3);
+
+        centerPane = TableLayoutHelper.createGapTableLayoutPane(components, rowSize, columnSize, 4, 6);
+        centerPane.setBorder(BorderFactory.createEmptyBorder(0, 0, 0, 1));
+        this.setLayout(new BorderLayout());
+        this.add(centerPane, BorderLayout.CENTER);
+    }
+
+    protected Component[][] getUseComponent(UILabel Label1, UILabel Label2, UILabel Label3) {
+        return new Component[][]{
                 new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesName, null, null, Label1, null})},
                 new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesValue, null, null, Label2, null})},
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{calculateCombox, null, null, Label3, null})},
                 new Component[]{new JSeparator()},
                 new Component[]{new BoldFontTextLabel(Inter.getLocText("Chart-Data_Filter"))},
         };
+    }
 
-        centerPane = TableLayoutHelper.createGapTableLayoutPane(components, rowSize, columnSize, 4, 6);
-        centerPane.setBorder(BorderFactory.createEmptyBorder(0, 0, 0, 1));
-        this.setLayout(new BorderLayout());
-        this.add(centerPane, BorderLayout.CENTER);
+    protected Component[][] getUseComponentWithOutFilter(UILabel Label1, UILabel Label2, UILabel Label3) {
+        return new Component[][]{
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesName, null, null, Label1, null})},
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesValue, null, null, Label2, null})},
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{calculateCombox, null, null, Label3, null})}
+        };
+    }
+
+    protected Component[][] getUseComponentWithOutSummary(UILabel Label1, UILabel Label2, UILabel Label3) {
+        return new Component[][]{
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesName, null, null, Label1, null})},
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesValue, null, null, Label2, null})},
+                new Component[]{new JSeparator()},
+                new Component[]{new BoldFontTextLabel(Inter.getLocText("Chart-Data_Filter"))},
+        };
+    }
+
+    protected Component[][] getUseComponentWithOutFilterAndSummary(UILabel Label1, UILabel Label2, UILabel Label3) {
+        return new Component[][]{
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesName, null, null, Label1, null})},
+                new Component[]{GUICoreUtils.createBorderLayoutPane(new Component[]{seriesValue, null, null, Label2, null})}
+        };
     }
 
     /**
diff --git a/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesTypeUseComboxPane.java b/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesTypeUseComboxPane.java
index 419af6bf36..1c505e0763 100644
--- a/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesTypeUseComboxPane.java
+++ b/designer_chart/src/com/fr/design/mainframe/chart/gui/data/table/SeriesTypeUseComboxPane.java
@@ -93,14 +93,22 @@ public class SeriesTypeUseComboxPane extends UIComboBoxPane<ChartCollection> {
 
     @Override
     protected List<FurtherBasicBeanPane<? extends ChartCollection>> initPaneList() {
-        nameFieldValuePane = new SeriesNameUseFieldValuePane();
-        nameFieldNamePane = new SeriesNameUseFieldNamePane();
+        nameFieldValuePane = createValuePane();
+        nameFieldNamePane = createNamePane();
         List<FurtherBasicBeanPane<? extends ChartCollection>> paneList = new ArrayList<FurtherBasicBeanPane<? extends ChartCollection>>();
         paneList.add(nameFieldValuePane);
         paneList.add(nameFieldNamePane);
         return paneList;
     }
 
+    protected SeriesNameUseFieldValuePane createValuePane() {
+        return new SeriesNameUseFieldValuePane();
+    }
+
+    protected SeriesNameUseFieldNamePane createNamePane() {
+        return new SeriesNameUseFieldNamePane();
+    }
+
     public void populateBean(ChartCollection ob, boolean isNeedSummary) {
         this.isNeedSummary = isNeedSummary;
         TopDefinitionProvider definition = ob.getSelectedChart().getFilterDefinition();