From db5a84339098316d9d188182f8f436e203dc9001 Mon Sep 17 00:00:00 2001
From: xiaoxia <xiaoxia@finereport.com>
Date: Thu, 19 Jan 2017 15:49:26 +0800
Subject: [PATCH] rt

---
 .../gui/icontainer/UIResizableContainer.java  |  3 ++-
 .../parameter/ParameterPropertyPane.java      | 27 ++++++++++++++-----
 .../parameter/ParameterToolBarPane.java       |  6 ++---
 3 files changed, 25 insertions(+), 11 deletions(-)

diff --git a/designer_base/src/com/fr/design/gui/icontainer/UIResizableContainer.java b/designer_base/src/com/fr/design/gui/icontainer/UIResizableContainer.java
index d16622184f..98fab75f0f 100644
--- a/designer_base/src/com/fr/design/gui/icontainer/UIResizableContainer.java
+++ b/designer_base/src/com/fr/design/gui/icontainer/UIResizableContainer.java
@@ -14,6 +14,7 @@ import java.awt.event.MouseMotionListener;
 
 public class UIResizableContainer extends JPanel {
     private static final long serialVersionUID = 1854340560790476907L;
+    private static final int MAX_PARA_HEIGHT = 240;
     private int containerWidth = 240;
     private int preferredWidth = 240;
     private int toolPaneY = 300;
@@ -139,7 +140,7 @@ public class UIResizableContainer extends JPanel {
      * @param height
      */
     public void setParameterHeight(int height) {
-        paraHeight = hasParameterPane? height : 0;
+        paraHeight = hasParameterPane? Math.min(height, MAX_PARA_HEIGHT) : 0;
         refreshContainer();
 
     }
diff --git a/designer_form/src/com/fr/design/parameter/ParameterPropertyPane.java b/designer_form/src/com/fr/design/parameter/ParameterPropertyPane.java
index f093a14327..9fbe3e6197 100644
--- a/designer_form/src/com/fr/design/parameter/ParameterPropertyPane.java
+++ b/designer_form/src/com/fr/design/parameter/ParameterPropertyPane.java
@@ -1,5 +1,6 @@
 package com.fr.design.parameter;
 
+import com.fr.design.dialog.BasicScrollPane;
 import com.fr.design.gui.ibutton.UIButton;
 import com.fr.design.mainframe.FormDesigner;
 import com.fr.design.mainframe.FormHierarchyTreePane;
@@ -13,13 +14,12 @@ import java.awt.event.MouseEvent;
 
 public class ParameterPropertyPane extends JPanel{
 	private ParameterToolBarPane toolbarPane;
-
-//	private JWorkBook workbook;
+	private BasicScrollPane basicScrollPane;
 	private ParaDefinitePane paraPane;
 
 	public static ParameterPropertyPane THIS;
 	private boolean isEditing = false;
-	
+
 	public static final ParameterPropertyPane getInstance() {
 		if(THIS == null) {
 			THIS = new ParameterPropertyPane();
@@ -43,12 +43,26 @@ public class ParameterPropertyPane extends JPanel{
 
 	public ParameterPropertyPane() {
 		toolbarPane = new ParameterToolBarPane();
+		basicScrollPane = new BasicScrollPane() {
+			@Override
+			protected JPanel createContentPane() {
+				return toolbarPane;
+			}
 
-		initParameterListener();
+			@Override
+			public void populateBean(Object ob) {
 
+			}
+
+			@Override
+			protected String title4PopupWindow() {
+				return null;
+			}
+		};
+		initParameterListener();
         this.setLayout(new BorderLayout(0, 6));
         this.setBorder(BorderFactory.createEmptyBorder(0, 5, 0, 0));
-        this.add(toolbarPane, BorderLayout.CENTER);
+        this.add(basicScrollPane, BorderLayout.CENTER);
 	}
 	
 	private void setEditor(FormDesigner editor) {
@@ -68,8 +82,9 @@ public class ParameterPropertyPane extends JPanel{
 				SwingUtilities.invokeLater(new Runnable() {
 					@Override
 					public void run() {
-						if (paraPane.isWithQueryButton())
+						if (paraPane.isWithQueryButton()) {
 							paraPane.addingParameter2Editor(toolbarPane.getTargetParameter(parameterSelectedLabel));
+						}
 						else {
 							paraPane.addingParameter2EditorWithQueryButton(toolbarPane.getTargetParameter(parameterSelectedLabel));
 						}
diff --git a/designer_form/src/com/fr/design/parameter/ParameterToolBarPane.java b/designer_form/src/com/fr/design/parameter/ParameterToolBarPane.java
index aa7c11660a..b2e4762faa 100644
--- a/designer_form/src/com/fr/design/parameter/ParameterToolBarPane.java
+++ b/designer_form/src/com/fr/design/parameter/ParameterToolBarPane.java
@@ -11,7 +11,6 @@ import java.util.ArrayList;
 import javax.swing.BorderFactory;
 import com.fr.design.gui.ilable.UILabel;
 import javax.swing.SwingConstants;
-import javax.swing.event.ChangeListener;
 
 import com.fr.base.Parameter;
 import com.fr.design.beans.BasicBeanPane;
@@ -23,7 +22,7 @@ import com.fr.general.Inter;
  * @author: august
  * */
 public class ParameterToolBarPane extends BasicBeanPane<Parameter[]> {
-	private Parameter[] parameterList;
+	public Parameter[] parameterList;
 	private ArrayList<UIButton> parameterSelectedLabellist = new ArrayList<UIButton>();
 	private MouseListener paraMouseListner;
 	private UIButton addAll;
@@ -35,7 +34,6 @@ public class ParameterToolBarPane extends BasicBeanPane<Parameter[]> {
 	private static final int GAP_BV = 4;
 	private static final int BUTTON_HEIGHT = 20;
 	private static final int WIDTH = 225;
-
 	private static final int L_H = 18;
 
 	public ParameterToolBarPane() {
@@ -133,7 +131,7 @@ public class ParameterToolBarPane extends BasicBeanPane<Parameter[]> {
 
 			layoutContainer(parent);
 
-			int h= ((parameterSelectedLabellist.size() == 0) ? L_H : breakid * (BUTTON_HEIGHT + GAP_V) + GAP_BV + L_H + GAP_H + addAll.getPreferredSize().height);
+			int h= ((parameterSelectedLabellist.size() == 0) ? 0 : breakid * (BUTTON_HEIGHT + GAP_V) + GAP_BV + L_H + GAP_H + addAll.getPreferredSize().height);
 			return new Dimension(w, h);
 		}