From d63dc7eb3ccd8910b8643f62141a70dbdab7aa1a Mon Sep 17 00:00:00 2001 From: hzzz Date: Mon, 30 Oct 2017 10:55:03 +0800 Subject: [PATCH 1/4] REPORT-4892 --- .../tabledatapane/DBTableDataPane.java | 1 + .../src/com/fr/design/images/data/field.png | Bin 1109 -> 190 bytes 2 files changed, 1 insertion(+) diff --git a/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java b/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java index 947e17106..8919535f0 100644 --- a/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java +++ b/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java @@ -184,6 +184,7 @@ public class DBTableDataPane extends AbstractTableDataPane { toolBarDef.addShortCut(dbTableDataMenuHandler.createQueryAction()); } isShareCheckBox = new UICheckBox(Inter.getLocText("FR-Designer_Is_Share_DBTableData")); + isShareCheckBox.setBackground(Color.WHITE); maxPanel = new MaxMemRowCountPanel(); maxPanel.setBorder(null); UIToolbar editToolBar = ToolBarDef.createJToolBar(); diff --git a/designer_base/src/com/fr/design/images/data/field.png b/designer_base/src/com/fr/design/images/data/field.png index 080cc1077812ee20e2f20a3749fa13e46095f30c..3ce09b689596a926c442ff6e9383d49ac9ef87ab 100644 GIT binary patch delta 153 zcmV;K0A~Ny2)+T383+ad001BJ|6!3K7=IabMObuGZ)S9NVRB^vL1b@YWgtmyVP|Dh zWnpA_ami&o0000>Nkl}O34_suG#Cs32rvMd5NIG2r8|NE0000}1 zg`_yJGB6%#IhM}Ap}@n~z;H+a%1BDAIDLTQvB9QK1`I3$&5IN!sIrL)rU$ZcD2OfC z^C4P+?c;sJ(?&o!Zf4=b)oN Date: Mon, 30 Oct 2017 12:00:17 +0800 Subject: [PATCH 2/4] REPORT-4892 --- .../src/com/fr/design/images/m_format/cell.png | Bin 374 -> 477 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/designer_base/src/com/fr/design/images/m_format/cell.png b/designer_base/src/com/fr/design/images/m_format/cell.png index 2f42e1e4ca41e4604de566b7a115e46e3871b842..e000c81b7c654076c7a359f25b2f5cd412e08af1 100644 GIT binary patch delta 451 zcmV;!0X+Wp0^I|UB!2;OQb$4nuFf3k0004(NkliA^b`Cx3*TFPFiQA^F3_Sj5iFqQ4m+2S}y{6Nt z@oKf|1qlEcN?7F?s@cGs^;XL%DrKz_d6x{1$77jhv*~`>LNp5xRco)pHk6z(&HNp@ zPlTBMfZf3mLq{kPdIUepxpx3a*#q&%%OOev zBpCqI>;R2YAx~(D@gj;qnpc zwE`fnhe`(m4OG~`f=4qfP(gqnh~HxghYd`4qPT%T8Zy9^4v=k^hxr}o)CMHE|HuX~ tVbLsr7V_w6;2@Ni2dQNo@Z1OxU;uRtT|77&0DS-e002ovPDHLkV1j5(gvkH^ From ef32c7aa0fadaa192bae13a6bc4f4574e9f725fd Mon Sep 17 00:00:00 2001 From: hzzz Date: Wed, 1 Nov 2017 14:12:38 +0800 Subject: [PATCH 3/4] sonarqube --- .../tabledatapane/DBTableDataPane.java | 68 +++++++++++-------- 1 file changed, 38 insertions(+), 30 deletions(-) diff --git a/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java b/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java index 8919535f0..af928dee6 100644 --- a/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java +++ b/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java @@ -54,6 +54,7 @@ import java.util.ArrayList; import java.util.List; public class DBTableDataPane extends AbstractTableDataPane { + private static final int BOTTOM = 6; private static final String PREVIEW_BUTTON = Inter.getLocText("FR-Designer_Preview"); private static final String REFRESH_BUTTON = Inter.getLocText("FR-Designer_Refresh"); private ConnectionTableProcedurePane connectionTableProcedurePane; @@ -66,29 +67,9 @@ public class DBTableDataPane extends AbstractTableDataPane { private String pageQuery = null; private DBTableData dbTableData; - - - public DBTableDataPane() { - this.setLayout(new BorderLayout(4, 4)); - - Box box = new Box(BoxLayout.Y_AXIS); - + private void init() { sqlTextPane = new SQLEditPane(); sqlTextPane.setSyntaxEditingStyle(SyntaxConstants.SYNTAX_STYLE_SQL); - JPanel northPane = new JPanel(new BorderLayout(4, 4)); - JToolBar editToolBar = createToolBar(); - northPane.add(editToolBar, BorderLayout.CENTER); - northPane.setBorder(BorderFactory.createEmptyBorder(0, 0, 6, 0)); - - RTextScrollPane sqlTextScrollPane = new RTextScrollPane(sqlTextPane); - sqlTextScrollPane.setLineNumbersEnabled(true); - sqlTextScrollPane.setBorder(new UIRoundedBorder(UIConstants.LINE_COLOR, 1, UIConstants.ARC)); - sqlTextScrollPane.setPreferredSize(new Dimension(680, 600)); - - JPanel paraMeanPane = new JPanel(new BorderLayout()); - paraMeanPane.setPreferredSize(new Dimension(680, 90)); - UILabel paraMean = new UILabel(Inter.getLocText("FR-Designer-Datasource-Param_DES")); - paraMeanPane.add(paraMean, BorderLayout.CENTER); ParameterTableModel model = new ParameterTableModel() { @Override @@ -98,14 +79,6 @@ public class DBTableDataPane extends AbstractTableDataPane { }; editorPane = new UITableEditorPane(model); - box.add(northPane); - box.add(sqlTextScrollPane); - box.add(paraMeanPane); - box.add(editorPane); - - JPanel sqlSplitPane = new JPanel(new BorderLayout(4, 4)); - sqlSplitPane.add(box, BorderLayout.CENTER); - // 左边的Panel,上面是选择DatabaseConnection的ComboBox,下面DatabaseConnection对应的Table connectionTableProcedurePane = new ConnectionTableProcedurePane() { @Override @@ -131,7 +104,7 @@ public class DBTableDataPane extends AbstractTableDataPane { }); sqlTextPane.addFocusListener(new FocusListener() { public void focusGained(FocusEvent e) { - + // unsupport } public void focusLost(FocusEvent e) { @@ -140,6 +113,40 @@ public class DBTableDataPane extends AbstractTableDataPane { } } }); + } + + public DBTableDataPane() { + init(); + this.setLayout(new BorderLayout(4, 4)); + + Box box = new Box(BoxLayout.Y_AXIS); + + + JPanel northPane = new JPanel(new BorderLayout(4, 4)); + JToolBar editToolBar = createToolBar(); + northPane.add(editToolBar, BorderLayout.CENTER); + northPane.setBorder(BorderFactory.createEmptyBorder(0, 0, BOTTOM, 0)); + + RTextScrollPane sqlTextScrollPane = new RTextScrollPane(sqlTextPane); + sqlTextScrollPane.setLineNumbersEnabled(true); + sqlTextScrollPane.setBorder(new UIRoundedBorder(UIConstants.LINE_COLOR, 1, UIConstants.ARC)); + sqlTextScrollPane.setPreferredSize(new Dimension(680, 600)); + + JPanel paraMeanPane = new JPanel(new BorderLayout()); + paraMeanPane.setPreferredSize(new Dimension(680, 90)); + UILabel paraMean = new UILabel(Inter.getLocText("FR-Designer-Datasource-Param_DES")); + paraMeanPane.add(paraMean, BorderLayout.CENTER); + + + box.add(northPane); + box.add(sqlTextScrollPane); + box.add(paraMeanPane); + box.add(editorPane); + + JPanel sqlSplitPane = new JPanel(new BorderLayout(4, 4)); + sqlSplitPane.add(box, BorderLayout.CENTER); + + box.setMinimumSize(new Dimension(310, 400)); // 使用SplitPane JSplitPane mainSplitPane = new JSplitPane(JSplitPane.HORIZONTAL_SPLIT, true, connectionTableProcedurePane, sqlSplitPane); @@ -297,6 +304,7 @@ public class DBTableDataPane extends AbstractTableDataPane { @Override public void checkEnabled() { + // unsupport } } From 4e945a165808de1f9ec635a7200530d8e319e311 Mon Sep 17 00:00:00 2001 From: hzzz Date: Wed, 1 Nov 2017 14:15:29 +0800 Subject: [PATCH 4/4] sonarqube --- .../tabledata/tabledatapane/DBTableDataPane.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java b/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java index af928dee6..85c75e329 100644 --- a/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java +++ b/designer_base/src/com/fr/design/data/tabledata/tabledatapane/DBTableDataPane.java @@ -68,6 +68,8 @@ public class DBTableDataPane extends AbstractTableDataPane { private DBTableData dbTableData; private void init() { + this.setLayout(new BorderLayout(4, 4)); + sqlTextPane = new SQLEditPane(); sqlTextPane.setSyntaxEditingStyle(SyntaxConstants.SYNTAX_STYLE_SQL); @@ -115,10 +117,8 @@ public class DBTableDataPane extends AbstractTableDataPane { }); } - public DBTableDataPane() { - init(); - this.setLayout(new BorderLayout(4, 4)); + private void initMainSplitPane() { Box box = new Box(BoxLayout.Y_AXIS); @@ -155,6 +155,12 @@ public class DBTableDataPane extends AbstractTableDataPane { this.add(mainSplitPane, BorderLayout.CENTER); } + public DBTableDataPane() { + init(); + initMainSplitPane(); + } + + private boolean isPreviewOrRefreshButton (FocusEvent e) { if (e.getOppositeComponent() != null) {