From 35ce746187cb0eeb5eba5c20cbc0b3dbc4d8efaf Mon Sep 17 00:00:00 2001
From: pengda <pengda@fanruan.com>
Date: Fri, 24 Jun 2022 15:43:26 +0800
Subject: [PATCH] =?UTF-8?q?REPORT-71839=20=E8=AE=BE=E8=AE=A1=E5=99=A8?=
 =?UTF-8?q?=E5=90=AF=E5=8A=A8=E6=97=B6=E5=90=AF=E5=8A=A8=E6=9C=8D=E5=8A=A1?=
 =?UTF-8?q?=E5=99=A8=EF=BC=8C=E4=BB=8D=E8=BF=9E=E6=9B=BE=E6=96=AD=E5=BC=80?=
 =?UTF-8?q?=E7=9A=84=E6=9C=8D=E5=8A=A1=E5=99=A8=EF=BC=8C=E4=BC=9A=E6=9C=89?=
 =?UTF-8?q?=E8=BF=9C=E7=A8=8B=E6=9B=B4=E6=96=B0=E6=8F=90=E9=86=92?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../java/com/fr/design/EnvChangeEntrance.java |  4 +++-
 .../versioncheck/VersionCheckUtils.java       | 21 ++++++++++++++++---
 .../main/java/com/fr/start/BaseDesigner.java  | 10 +++++++++
 .../module/DesignerWorkspaceProvider.java     | 12 -----------
 4 files changed, 31 insertions(+), 16 deletions(-)

diff --git a/designer-base/src/main/java/com/fr/design/EnvChangeEntrance.java b/designer-base/src/main/java/com/fr/design/EnvChangeEntrance.java
index 7d2fc61065..6cb50776c5 100644
--- a/designer-base/src/main/java/com/fr/design/EnvChangeEntrance.java
+++ b/designer-base/src/main/java/com/fr/design/EnvChangeEntrance.java
@@ -433,7 +433,9 @@ public class EnvChangeEntrance {
                     DesignerExiter.getInstance().execute();
                 } else {
                     updateNotRememberPwdEnv();
-                    VersionCheckUtils.showVersionCheckDialog(envListPane.getSelectedName());
+                    if (DesignerContext.getDesignerFrame().isVisible()) {
+                        VersionCheckUtils.showVersionCheckDialog(envListPane.getSelectedName());
+                    }
                 }
             }
 
diff --git a/designer-base/src/main/java/com/fr/design/versioncheck/VersionCheckUtils.java b/designer-base/src/main/java/com/fr/design/versioncheck/VersionCheckUtils.java
index d2794cd6e6..55dfe60cf1 100644
--- a/designer-base/src/main/java/com/fr/design/versioncheck/VersionCheckUtils.java
+++ b/designer-base/src/main/java/com/fr/design/versioncheck/VersionCheckUtils.java
@@ -52,6 +52,7 @@ import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
+import javax.swing.SwingWorker;
 
 /**
  * @author pengda
@@ -95,9 +96,23 @@ public class VersionCheckUtils {
     }
 
     public static void showVersionCheckDialog(String envName) {
-        if (!VersionCheckUtils.versionCheck(envName)) {
-            showNotificationDialog(envName);
-        }
+        new SwingWorker<Boolean, Void>() {
+            @Override
+            protected Boolean doInBackground() {
+                return !VersionCheckUtils.versionCheck(envName);
+            }
+
+            @Override
+            protected void done() {
+                try {
+                    if (get()) {
+                        showNotificationDialog(envName);
+                    }
+                } catch (Exception e) {
+                    FineLoggerFactory.getLogger().warn(e.getMessage(), e);
+                }
+            }
+        }.execute();
     }
 
     private static void showNotificationDialog(String envName) {
diff --git a/designer-base/src/main/java/com/fr/start/BaseDesigner.java b/designer-base/src/main/java/com/fr/start/BaseDesigner.java
index 95f27442d4..97355c8fea 100644
--- a/designer-base/src/main/java/com/fr/start/BaseDesigner.java
+++ b/designer-base/src/main/java/com/fr/start/BaseDesigner.java
@@ -18,6 +18,7 @@ import com.fr.design.mainframe.DesignerFrame;
 import com.fr.design.mainframe.toolbar.ToolBarMenuDock;
 import com.fr.design.monitor.DesignerLifecycleMonitorContext;
 import com.fr.design.ui.util.UIUtil;
+import com.fr.design.versioncheck.VersionCheckUtils;
 import com.fr.event.Event;
 import com.fr.event.EventDispatcher;
 import com.fr.event.Listener;
@@ -90,10 +91,19 @@ public abstract class BaseDesigner extends ToolBarMenuDock {
                 EventDispatcher.fire(WorkspaceStatus.Prepared);
                 EventDispatcher.asyncFire(LazyStartupEvent.INSTANCE);
                 collectUserInformation();
+                checkVersion();
             }
         });
     }
 
+    private void checkVersion() {
+        try {
+            VersionCheckUtils.showVersionCheckDialog(DesignerEnvManager.getEnvManager().getCurEnvName());
+        } catch (Exception e) {
+            FineLoggerFactory.getLogger().warn("Check Service Failed");
+        }
+    }
+
     public void show() {
         UIUtil.invokeLaterIfNeeded(this::refreshTemplateTree);
     }
diff --git a/designer-realize/src/main/java/com/fr/start/module/DesignerWorkspaceProvider.java b/designer-realize/src/main/java/com/fr/start/module/DesignerWorkspaceProvider.java
index de57164bcb..5abeccc842 100644
--- a/designer-realize/src/main/java/com/fr/start/module/DesignerWorkspaceProvider.java
+++ b/designer-realize/src/main/java/com/fr/start/module/DesignerWorkspaceProvider.java
@@ -56,18 +56,6 @@ public class DesignerWorkspaceProvider extends Activator {
                     EnvChangeEntrance.getInstance().dealEvnExceptionWhenStartDesigner(null, workspaceInfo);
                 } else {
                     WorkContext.switchTo(workspace);
-                    //在设计器完全启动完成后，对初始环境进行一次服务检测，对主要功能无影响，异常仅做日志提示即可
-                    final String selectEnv = current;
-                    EventDispatcher.listen(DesignerLaunchStatus.STARTUP_COMPLETE, new Listener<Null>() {
-                        @Override
-                        public void on(Event event, Null aNull) {
-                            try {
-                               VersionCheckUtils.showVersionCheckDialog(selectEnv);
-                            } catch (Exception e) {
-                                FineLoggerFactory.getLogger().warn("Check Service Failed");
-                            }
-                        }
-                    });
                 }
             } catch (Throwable e) {
                 EnvChangeEntrance.getInstance().dealEvnExceptionWhenStartDesigner(e, workspaceInfo);