From 9b7d3f41edc57a46c8ab54440c29f121dfd0c8e2 Mon Sep 17 00:00:00 2001
From: Jochen Berger <fooberger@gmail.com>
Date: Mon, 13 May 2013 13:18:32 +0200
Subject: [PATCH] forbid usage of collection-related filters on multi-level
 paths as they would most likely be ambigous

---
 .../src/main/java/com/jayway/jsonpath/Criteria.java    | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/json-path/src/main/java/com/jayway/jsonpath/Criteria.java b/json-path/src/main/java/com/jayway/jsonpath/Criteria.java
index 8ec72e4c..e43ca4a0 100644
--- a/json-path/src/main/java/com/jayway/jsonpath/Criteria.java
+++ b/json-path/src/main/java/com/jayway/jsonpath/Criteria.java
@@ -422,6 +422,7 @@ public class Criteria {
       */
     public Criteria in(Collection<?> c) {
         notNull(c, "collection can not be null");
+        checkFilterCanBeApplied(CriteriaType.IN);
         criteria.put(CriteriaType.IN, c);
         return this;
     }
@@ -446,6 +447,7 @@ public class Criteria {
      */
     public Criteria nin(Collection<?> c) {
         notNull(c, "collection can not be null");
+        checkFilterCanBeApplied(CriteriaType.NIN);
         criteria.put(CriteriaType.NIN, c);
         return this;
     }
@@ -468,6 +470,7 @@ public class Criteria {
      */
     public Criteria all(Collection<?> c) {
         notNull(c, "collection can not be null");
+        checkFilterCanBeApplied(CriteriaType.ALL);
         criteria.put(CriteriaType.ALL, c);
         return this;
     }
@@ -479,6 +482,7 @@ public class Criteria {
      * @return
      */
     public Criteria size(int s) {
+        checkFilterCanBeApplied(CriteriaType.SIZE);
         criteria.put(CriteriaType.SIZE, s);
         return this;
     }
@@ -552,6 +556,12 @@ public class Criteria {
         criteriaChain.add(new Criteria("$and").is(asList(criteria)));
         return this;
     }
+    
+    private void checkFilterCanBeApplied(CriteriaType type){
+      if (getKey().getTokenizer().size() > 2){
+        throw new IllegalArgumentException("Cannot use "+type+" filter on a multi-level path expression");
+      }
+    }
 
     
     private interface Predicate<T> {