Merge pull request #2019 from smart-techs/fix-2014

fix issue-2014

src/main/java/com/alibaba/excel/read/listener/ModelBuildEventListener.java

@@ -21,10 +21,13 @@ import com.alibaba.excel.util.MapUtils;
  *
  * @author jipengfei
  */
-public class ModelBuildEventListener implements ReadListener<Map<Integer, ReadCellData<?>>> {
+public class ModelBuildEventListener extends AbstractIgnoreExceptionReadListener<Map<Integer, CellData>> {
+    private int headSize;
 
     @Override
-    public void invokeHead(Map<Integer, ReadCellData<?>> cellDataMap, AnalysisContext context) {}
+    public void invokeHead(Map<Integer, CellData> cellDataMap, AnalysisContext context) {
+        this.headSize = cellDataMap.size();
+    }
 
     @Override
     public void invoke(Map<Integer, ReadCellData<?>> cellDataMap, AnalysisContext context) {
@@ -40,23 +43,57 @@ public class ModelBuildEventListener implements ReadListener<Map<Integer, ReadCe
     private Object buildStringList(Map<Integer, ReadCellData<?>> cellDataMap, ReadSheetHolder readSheetHolder,
         AnalysisContext context) {
         int index = 0;
-        Map<Integer, String> map = MapUtils.newLinkedHashMapWithExpectedSize(cellDataMap.size());
+        if (context.readWorkbookHolder().getDefaultReturnMap()) {
-        for (Map.Entry<Integer, ReadCellData<?>> entry : cellDataMap.entrySet()) {
+            Map<Integer, String> map = new LinkedHashMap<Integer, String>(cellDataMap.size() * 4 / 3 + 1);
-            Integer key = entry.getKey();
+            for (Map.Entry<Integer, CellData> entry : cellDataMap.entrySet()) {
-            ReadCellData<?> cellData = entry.getValue();
+                Integer key = entry.getKey();
-            while (index < key) {
+                CellData cellData = entry.getValue();
+                while (index < key) {
+                    map.put(index, null);
+                    index++;
+                }
+                index++;
+                if (cellData.getType() == CellDataTypeEnum.EMPTY) {
+                    map.put(key, null);
+                    continue;
+                }
+                map.put(key,
+                    (String)ConverterUtils.convertToJavaObject(cellData, null, null, currentReadHolder.converterMap(),
+                        currentReadHolder.globalConfiguration(), context.readRowHolder().getRowIndex(), key));
+            }
+            int headSize = currentReadHolder.excelReadHeadProperty().getHeadMap().size() == 0
+                ? this.headSize : currentReadHolder.excelReadHeadProperty().getHeadMap().size();
+            while (index < headSize) {
                 map.put(index, null);
                 index++;
             }
-            index++;
+            return map;
-            map.put(key,
+        } else {
-                (String)ConverterUtils.convertToJavaObject(cellData, null, null, readSheetHolder.converterMap(),
+            // Compatible with the old code the old code returns a list
-                    context, context.readRowHolder().getRowIndex(), key));
+            List<String> list = new ArrayList<String>();
-        }
+            for (Map.Entry<Integer, CellData> entry : cellDataMap.entrySet()) {
-        int headSize = readSheetHolder.excelReadHeadProperty().getHeadMap().size();
+                Integer key = entry.getKey();
-        while (index < headSize) {
+                CellData cellData = entry.getValue();
-            map.put(index, null);
+                while (index < key) {
-            index++;
+                    list.add(null);
+                    index++;
+                }
+                index++;
+                if (cellData.getType() == CellDataTypeEnum.EMPTY) {
+                    list.add(null);
+                    continue;
+                }
+                list.add(
+                    (String)ConverterUtils.convertToJavaObject(cellData, null, null, currentReadHolder.converterMap(),
+                        currentReadHolder.globalConfiguration(), context.readRowHolder().getRowIndex(), key));
+            }
+            int headSize = currentReadHolder.excelReadHeadProperty().getHeadMap().size() == 0
+                ? this.headSize : currentReadHolder.excelReadHeadProperty().getHeadMap().size();
+            while (index < headSize) {
+                list.add(null);
+                index++;
+            }
+            return list;
         }
         return map;
     }