From fd15016024ee9bf2a25b5b35946e97458d5f98c7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E7=99=BD=E5=B2=B3?= <445798420@qq.com>
Date: Thu, 9 Apr 2020 15:28:33 +0800
Subject: [PATCH] =?UTF-8?q?CHART-12791=20=E5=8E=BB=E6=8E=89=E5=9F=8B?=
 =?UTF-8?q?=E7=82=B9=E4=B8=AD=E7=9A=84=E7=B1=BB=E5=9E=8B=E5=88=A4=E6=96=AD?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../chart/info/ChartInfoCollector.java        | 37 ++++++-------------
 1 file changed, 11 insertions(+), 26 deletions(-)

diff --git a/designer-base/src/main/java/com/fr/design/mainframe/chart/info/ChartInfoCollector.java b/designer-base/src/main/java/com/fr/design/mainframe/chart/info/ChartInfoCollector.java
index bfc5a0d35..5b76b197c 100644
--- a/designer-base/src/main/java/com/fr/design/mainframe/chart/info/ChartInfoCollector.java
+++ b/designer-base/src/main/java/com/fr/design/mainframe/chart/info/ChartInfoCollector.java
@@ -7,7 +7,6 @@ import com.fr.design.mainframe.template.info.TemplateInfo;
 import com.fr.design.mainframe.template.info.TemplateProcessInfo;
 import com.fr.general.ComparatorUtils;
 import com.fr.log.FineLoggerFactory;
-import com.fr.plugin.chart.vanchart.VanChart;
 import com.fr.stable.ProductConstants;
 import com.fr.stable.StableUtils;
 import com.fr.stable.StringUtils;
@@ -57,36 +56,29 @@ public class ChartInfoCollector extends AbstractPointCollector<ChartInfo> {
     }
 
     public void collection(ChartProvider chartProvider, String createTime, boolean isReuse) {
-        if (chartProvider instanceof VanChart) {
-            VanChart vanChart = (VanChart) chartProvider;
-            collection(vanChart.getUuid(), vanChart.getID(), createTime, isReuse);
-        }
+        collection(chartProvider.getChartUuid(), chartProvider.getID(), createTime, isReuse);
     }
 
     /**
      * 新建图表，保存状态
      */
     public void collection(String chartId, String chartType, String createTime, boolean isReuse) {
-        if (!shouldCollectInfo()) {
+        if (!shouldCollectInfo() || StringUtils.isEmpty(chartId)) {
             return;
         }
-
         ChartInfo chartInfo = ChartInfo.newInstance(chartId, chartType, createTime, true, isReuse);
         chartInfoCacheMap.put(chartId, chartInfo);
     }
 
     public void updateChartPropertyTime(ChartProvider chartProvider) {
-        if (chartProvider instanceof VanChart) {
-            VanChart vanChart = (VanChart) chartProvider;
-            updateChartPropertyTime(vanChart.getUuid(), vanChart.getID());
-        }
+        updateChartPropertyTime(chartProvider.getChartUuid(), chartProvider.getID());
     }
 
     /**
      * 图表编辑，更新编辑时间
      */
     public void updateChartPropertyTime(String chartId, String chartType) {
-        if (!shouldCollectInfo()) {
+        if (!shouldCollectInfo() || StringUtils.isEmpty(chartId)) {
             return;
         }
         ChartInfo chartInfo = getOrCreateChartInfo(chartId, chartType, null);
@@ -99,17 +91,14 @@ public class ChartInfoCollector extends AbstractPointCollector<ChartInfo> {
     }
 
     public void updateChartTypeTime(ChartProvider chartProvider, String oldType) {
-        if (chartProvider instanceof VanChart) {
-            VanChart vanChart = (VanChart) chartProvider;
-            updateChartTypeTime(vanChart.getUuid(), vanChart.getID(), oldType);
-        }
+        updateChartTypeTime(chartProvider.getChartUuid(), chartProvider.getID(), oldType);
     }
 
     /**
      * 图表类型变化，更新类型和类型确认时间
      */
     public void updateChartTypeTime(String chartId, String chartType, String oldType) {
-        if (!shouldCollectInfo()) {
+        if (!shouldCollectInfo() || StringUtils.isEmpty(chartId)) {
             return;
         }
 
@@ -143,18 +132,14 @@ public class ChartInfoCollector extends AbstractPointCollector<ChartInfo> {
     }
 
     public void checkTestChart(ChartProvider chartProvider) {
-        if (chartProvider instanceof VanChart) {
-            checkTestChart((VanChart) chartProvider);
-        }
-    }
-
-    public void checkTestChart(VanChart vanChart) {
         if (!shouldCollectInfo()) {
             return;
         }
-        boolean testChart = vanChart.isTestChart();
-        ChartInfo chartInfo = chartInfoCacheMap.get(vanChart.getUuid());
-        chartInfo.setTestChart(testChart);
+        ChartInfo chartInfo = chartInfoCacheMap.get(chartProvider.getChartUuid());
+        if (chartInfo != null) {
+            boolean testChart = chartProvider.isTestChart();
+            chartInfo.setTestChart(testChart);
+        }
     }
 
     /**